fix: workspace switcher is reset after refresh#59280
Conversation
|
The switcher shows the newly created workspace even when it is not switched with these steps: However, on staging, after switching, there is no filter, and all chats correctly show up. Screen.Recording.2025-03-31.at.12.46.42.PM.mov |
|
@c3024 I'm still investigating, will update soon. |
|
@c3024 I updated. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeswitchAndroid.movAndroid: mWeb ChromeswitchAndroidmWeb.moviOS: NativeswitchiOS.moviOS: mWeb SafariswitchiOSmWeb.movMacOS: Chrome / SafariswitchChrome.movMacOS: DesktopswitchDesktop.mov |
| /** The policyID of the last workspace whose settings were accessed by the user */ | ||
| LAST_ACCESSED_WORKSPACE_POLICY_ID: 'lastAccessedWorkspacePolicyID', | ||
|
|
||
| /** The policyID of the last workspace whose were accessed by the user via workspace switcher */ |
There was a problem hiding this comment.
| /** The policyID of the last workspace whose were accessed by the user via workspace switcher */ | |
| /** The policyID of the last workspace that was accessed by the user via workspace switcher */ |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/francoisl in version: 9.1.24-2 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀
|
Explanation of Change
Fixed Issues
$ #58611
PROPOSAL: #58611 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-03-31.at.10.23.58.mov
Android: mWeb Chrome
Screen.Recording.2025-03-31.at.10.25.40.mov
iOS: Native
Screen.Recording.2025-03-31.at.10.25.56.mov
iOS: mWeb Safari
Screen.Recording.2025-03-31.at.10.26.26.mov
MacOS: Chrome / Safari
Screen.Recording.2025-03-31.at.10.27.04.mov
MacOS: Desktop
Screen.Recording.2025-03-31.at.10.27.24.mov